Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve auto unmount #267

Closed
wants to merge 5 commits into from
Closed

Improve auto unmount #267

wants to merge 5 commits into from

Conversation

benrubson
Copy link
Contributor

@benrubson benrubson commented Jan 20, 2017 •
edited
Loading

See #293 for a rework.

Hello,

Here is a PR to improve auto unmount.
It is now :

  • more secure because encfs will not exit if unmount failed ;
  • libfuse3 compatible because it does not use fuse_unmount_compat22 anymore, which has been removed from libfuse3.

Thank you 👍

Ben

Improve auto unmount
b17838a 
more secure & libfuse3 compatible
@benrubson benrubson mentioned this pull request Jan 20, 2017
Closed
@benrubson
Copy link
Contributor Author

@vgough @rfjakob, could we flag this in project 1.9.2 release please ?
Many thanks 👍

@rfjakob
Copy link
Collaborator

rfjakob commented Feb 5, 2017 •
edited
Loading

Phew, this is replacing a library call with an external program spawn and adding shell injection vulnerabilities on the way. Can't we call fuse_unmount somehow?

@rfjakob rfjakob self-assigned this Feb 5, 2017
@benrubson
Copy link
Contributor Author

If you look at fuse_unmount_compat22 code, it also calls umountbinary :)
This is why I did it this way.
However I did not look at fuse_unmount, perhaps we could use it yes.

@benrubson
Copy link
Contributor Author

See #293 for a one-commit PR.
Thx !

@benrubson benrubson closed this Mar 9, 2017
@benrubson benrubson deleted the unmount branch March 9, 2017 11:17
@benrubson benrubson mentioned this pull request Mar 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rfjakob rfjakob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benrubson @rfjakob